On Wednesday 22 October 2014 10:04:45 Maxim Dounin wrote:
> > The script to extract all directives is also attached. I also compared the
> > output against the list on http://nginx.org/en/docs/dirindex.html and noticed
> > that some directives are missing on that page,
>
> Some directives are undocumented on purpose. E.g., acceptex_read
> directive you've added in your patch is from never worked
> unfinished acceptex event handling module.

Ok, I'll keep it in the syntax file anyway, it is not documentation and does not
hurt. Why not remove the file if it is not used?

> > and that some typos are present
> > (for example, fascgi_force_ranges instead of "fastcgi_force_ranges").
>
> This means there is a typo in the directive name in docs. This on
> fixed, thanks:
>
> http://hg.nginx.org/nginx.org/rev/c63717ebc5bc
>
> (BTW, patches for docs are also welcome.)

Didn't know that the website was also in hg. Good to know in case I spot other
errors.

> > Contrib: add more directives to vim syntax
>
> Please add a trailing dot here.

Done.

> > --- a/contrib/README Wed Oct 15 22:57:23 2014 +0400
> > +++ b/contrib/README Sun Oct 19 16:08:33 2014 +0200
> > @@ -17,5 +17,5 @@ unicode2nginx by Maxim Dounin
> > vim by Evan Miller
> >
> > Syntax highlighting of nginx configuration for vim, to be
> > - placed into ~/.vim/.
> > + placed into ~/.vim/ or /usr/share/vim/vimfiles/.
>
> I would like to avoid platform-specific paths here.

Okay, I could not really find documentation on this so have just removed it.

> > syn keyword ngxDirective epoll_events
> > syn keyword ngxDirective error_log
> > +syn keyword ngxDirective error_log
>
> We probably don't wont duplicate directives here and in other
> places.

Yeah, I originally sorted the list of directives without using the '--unique'
option. This causes duplicate lines as error_log appears in the HTTP core and
log modules.

> > +syn keyword ngxDirective etag
> > syn keyword ngxDirective eventport_events
> > syn keyword ngxDirective expires
> > syn keyword ngxDirective fastcgi_bind
> > +syn keyword ngxDirective fastcgi_buffering
> > +syn keyword ngxDirective fastcgi_buffers
> > syn keyword ngxDirective fastcgi_buffer_size
> > -syn keyword ngxDirective fastcgi_buffers
>
> The change in order looks strange, in lowercase
> fastcgi_buffer_size should be before fastcgi_buffers and
> fastcgi_buffering.

Turns out to be a locale issue, forcing it with LC_ALL=C changed it to the
previous ordering.

Please find the updated patch attached.
--
Kind regards,
Peter
https://lekensteyn.nl
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel