Welcome! Log In Create A New Profile

Advanced

Re: Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Maxim Dounin
October 08, 2014 09:46AM
Hello!

On Tue, Oct 07, 2014 at 07:11:24PM +0000, Bondarev, Daniil wrote:

> Hey Maxim,
>
> > On the other hand, looking into this more closely, I tend to think
> > that ellipsis should be always added to make it clear that the
> > header logged is incomplete.
>
> Agree, good point!
>
> Patch looks good to me, only note - you can reduce amount of lines by ngx_min,
> if you wish:

I think the code is more readable as is, without ngx_min().
The patch comitted, thanks.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Bondarev, Daniil 820 October 07, 2014 01:26PM

Re: Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Maxim Dounin 278 October 07, 2014 01:56PM

RE: Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Bondarev, Daniil 309 October 07, 2014 02:12PM

Re: Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Maxim Dounin 271 October 07, 2014 03:00PM

RE: Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Bondarev, Daniil 318 October 07, 2014 03:12PM

Re: Prevent buffer overrun on NGX_HTTP_REQUEST_HEADER_TOO_LARGE

Maxim Dounin 340 October 08, 2014 09:46AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 153
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready