Welcome! Log In Create A New Profile

Advanced

Re: [BUG] New memory invalid read regression in resolver since nginx 1.7.5

Maxim Dounin
September 30, 2014 08:38PM
Hello!

On Tue, Sep 30, 2014 at 03:51:40PM -0700, Yichun Zhang (agentzh) wrote:

> Hello!
>
> On Tue, Sep 30, 2014 at 3:10 PM, Yichun Zhang (agentzh) wrote:
> > ngx_log_debug2(NGX_LOG_DEBUG_EVENT, ev->log, 0,
> > "event timer del: %d: %M",
> > ngx_event_ident(ev->data), ev->timer.key);
> >
>
> There is another issue here: it seems that ngx_event_ident() assumes
> ev->data is an ngx_connection_t pointer:
>
> #define ngx_event_ident(p) ((ngx_connection_t *) (p))->fd
>
> But in fact, ev->data can point to any thing. Maybe it makes more
> sense to just output the pointer value of ev->data here?
>
> How about the following patch?

With such a change timer idents will become much less readable
for connection-related timers (that is, most of them), so this
is a last resort.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[BUG] New memory invalid read regression in resolver since nginx 1.7.5

Yichun Zhang (agentzh) 1267 September 30, 2014 06:12PM

Re: [BUG] New memory invalid read regression in resolver since nginx 1.7.5

Yichun Zhang (agentzh) 351 September 30, 2014 06:52PM

Re: [BUG] New memory invalid read regression in resolver since nginx 1.7.5

Maxim Dounin 361 September 30, 2014 08:38PM

Re: [BUG] New memory invalid read regression in resolver since nginx 1.7.5

Yichun Zhang (agentzh) 399 October 01, 2014 03:38PM

Re: [BUG] New memory invalid read regression in resolver since nginx 1.7.5

Maxim Dounin 395 September 30, 2014 08:34PM

Re: [BUG] New memory invalid read regression in resolver since nginx 1.7.5

Ruslan Ermilov 355 November 18, 2014 05:26AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 174
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready