Hi Maxim,

Thanks for letting us know.

Our updated patch is located at http://forum.nginx.org/read.php?29,253446,253446#msg-253446

It supposes to address all the style issues and fixes the restart and binary upgrade issues. This is just a FYI in case you are not aware of.

Thanks,
Yingqi

-----Original Message-----
From: nginx-devel-bounces@nginx.org [mailto:nginx-devel-bounces@nginx.org] On Behalf Of Maxim Dounin
Sent: Wednesday, October 08, 2014 5:59 AM
To: nginx-devel@nginx.org
Subject: Re: [Patch] SO_REUSEPORT support from master process

Hello!

On Tue, Oct 07, 2014 at 07:32:08PM +0000, Lu, Yingqi wrote:

> Dear All,
>
> It has been quiet for a while on this patch. I am checking to see if
> there is any questions/feedbacks/concerns we need to address?
>
> Please let me know. Thanks very much for your help!

Apart from style/coding issues, I disagree with the whole approach.

As far as I understand the patch idea, it tries to introduce multiple listening sockets to avoid in-kernel lock contention.
This is something that can be done completely in kernel though, and I see no reason to introduce any changes to nginx here.

The approach previously discussed with Sepherosa Ziehau looks much more interesting.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel