Welcome! Log In Create A New Profile

Advanced

header value null termination?

August 21, 2014 07:32PM
I'm creating a module in which I needed to set some
of the standard headers e.g. Content-Range and Range.

Looking through the core source code the standard way
to do this seems to be something like this:-

r->headers_in.range->value.len =
ngx_sprintf(r->headers_in.range->value.data,
"bytes %O-%O/%O",
range->start, range->end - 1,
r->headers_out.content_length_n)
- r->headers_in.range->value.data;

This appears to write a string to value.data which
is not \0 terminated hence when interacting with
functions such as ngx_http_range_parse unpredictable
behaviour follows as it expects the range header to
be null terminated.

So the question is:-

Should header values be null terminated or should
functions such as ngx_http_range_parse be updated
to deal with non-null terminated strings?

Regards
Steve

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

header value null termination?

steveh 787 August 21, 2014 07:32PM

Re: header value null termination?

Maxim Dounin 327 August 25, 2014 10:34AM

Re: header value null termination?

steveh 703 August 25, 2014 02:58PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 142
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready