Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] SSL: let it build against LibreSSL

Piotr Sikora
July 29, 2014 10:16PM
Hey Maxim,

> As previously suggested, this doesn't looks like a right way to
> go. If LibreSSL folks continue to insist this is OpenSSL-2.0.0,
> then we'll probably have redefine OPENSSL_VERSION_NUMBER
> ourselves.

Unfortunately, it looks like they've made their mind :( The discussion
on it stopped, they've made 4 releases with that version already and
OpenBSD is in the release mode right now, so I don't expect that
they're going to change it.

Redefining OPENSSL_VERSION_NUMBER doesn't seem like the prettiest
solution, though.

> Same as for BoringSSL patch - I don't think we should add #if's
> here.

See my reply in the BoringSSL thread... I don't think that it makes
sense to keep setting the callback if we know that it doesn't do
anything. Effectively, we're masking the issue and pretending that the
feature works with BoringSSL and LibreSSL, simply because it compiles
(i.e. the thing you were worried about).

Best regards,
Piotr Sikora

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] SSL: let it build against LibreSSL

Piotr Sikora 878 July 29, 2014 07:22PM

Re: [PATCH] SSL: let it build against LibreSSL

Piotr Sikora 297 July 29, 2014 07:24PM

Re: [PATCH] SSL: let it build against LibreSSL

Maxim Dounin 297 July 29, 2014 08:56PM

Re: [PATCH] SSL: let it build against LibreSSL

Piotr Sikora 364 July 29, 2014 10:16PM

Re: [PATCH] SSL: let it build against LibreSSL

Maxim Dounin 262 July 30, 2014 08:24AM

Re: [PATCH] SSL: let it build against LibreSSL

Piotr Sikora 330 July 30, 2014 06:14PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 218
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready