Welcome! Log In Create A New Profile

Advanced

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Maxim Dounin
July 30, 2014 08:24AM
Hello!

On Tue, Jul 29, 2014 at 10:32:29PM -0700, Piotr Sikora wrote:

> Hey Maxim,
>
> > The problem is lots of added lines required to avoid calling it.
>
> Alternatively, would you be OK with a change that adds #ifndefs around
> SSL_CTX_set_tmp_rsa_callback() in ngx_http_ssl_module and
> ngx_mail_ssl_module, but keeps ngx_ssl_rsa512_key_callback without
> guards? It's exported, so compilers won't complain about it being
> unused.

I don't really think we at all need these ifdefs. Additionally, I
tend to think that we don't need SSL_CTX_set_tmp_rsa_callback() in
mail/http either, it should be hidden in openssl glue code.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 1 of 2] SSL: fix build with OPENSSL_NO_ENGINE and/or OPENSSL_NO_OCSP

Piotr Sikora 1125 July 28, 2014 07:06PM

[PATCH 2 of 2] SSL: let it build against BoringSSL

Piotr Sikora 368 July 28, 2014 07:06PM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Maxim Dounin 330 July 29, 2014 06:16PM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Piotr Sikora 295 July 29, 2014 07:20PM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Piotr Sikora 311 July 29, 2014 07:40PM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Maxim Dounin 328 July 30, 2014 12:22AM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Maxim Dounin 305 July 30, 2014 12:16AM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Piotr Sikora 313 July 30, 2014 12:58AM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Piotr Sikora 293 July 30, 2014 01:34AM

Re: [PATCH 2 of 2] SSL: let it build against BoringSSL

Maxim Dounin 379 July 30, 2014 08:24AM

Re: [PATCH 1 of 2] SSL: fix build with OPENSSL_NO_ENGINE and/or OPENSSL_NO_OCSP

Maxim Dounin 339 July 29, 2014 06:10PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 198
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready