Welcome! Log In Create A New Profile

Advanced

Re: Re: [PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

Maxim Dounin
June 25, 2014 02:14PM
Hello!

On Wed, Jun 25, 2014 at 10:00:35PM +0800, flygoast wrote:

> At here:
> in ngx_http_write_filter():
>
>
> if (limit
> && c->write->ready
> && c->sent - sent >= limit - (off_t) (2 * ngx_pagesize))
> {
> c->write->delayed = 1;
> ngx_add_timer(c->write, 1);
> }
>
>
> limit's value from clcf->sendfile_max_chunk. In my nginx.conf, I set "sendfile_max_chunk 8k;". I attached a debug log for this situation in last mail.

Well, so the problem happens with sendfile_max_chunk set lower
than proxy_buffer_size. While I don't think that
sendfile_max_chunk 8k is practical, it probably worth fixing.

I don't think that suggested patch is right
though - it will not prevent infinite stall of transfering a big
enough data chunk, as timer set by write filter will be removed.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

flygoast 723 June 25, 2014 07:26AM

Re:[PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

flygoast 552 June 25, 2014 07:30AM

Re: [PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

Maxim Dounin 362 June 25, 2014 09:10AM

Re:Re: [PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

flygoast 409 June 25, 2014 10:02AM

Re: Re: [PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

Maxim Dounin 370 June 25, 2014 02:14PM

Re:Re: Re: [PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

flygoast 454 June 25, 2014 11:12PM

Re: Re: Re: [PATCH]Upstream: fix possible request hang when "proxy_buffering" is off.

Maxim Dounin 415 June 26, 2014 08:10AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 164
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready