Welcome! Log In Create A New Profile

Advanced

[nginx] Core: fixed error handling in ngx_reopen_files().

Maxim Dounin
April 30, 2014 11:20AM
details: http://hg.nginx.org/nginx/rev/dfb3c15bc851
branches:
changeset: 5680:dfb3c15bc851
user: Maxim Dounin <mdounin@mdounin.ru>
date: Wed Apr 30 19:16:40 2014 +0400
description:
Core: fixed error handling in ngx_reopen_files().

Found by Coverity (CID 1087509).

diffstat:

src/core/ngx_cycle.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diffs (30 lines):

diff --git a/src/core/ngx_cycle.c b/src/core/ngx_cycle.c
--- a/src/core/ngx_cycle.c
+++ b/src/core/ngx_cycle.c
@@ -1104,6 +1104,8 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx
ngx_close_file_n " \"%s\" failed",
file[i].name.data);
}
+
+ continue;
}

if (fi.st_uid != user) {
@@ -1117,6 +1119,8 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx
ngx_close_file_n " \"%s\" failed",
file[i].name.data);
}
+
+ continue;
}
}

@@ -1133,6 +1137,8 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx
ngx_close_file_n " \"%s\" failed",
file[i].name.data);
}
+
+ continue;
}
}
}

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[nginx] Core: fixed error handling in ngx_reopen_files().

Maxim Dounin 621 April 30, 2014 11:20AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 288
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready