Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Parse: underscores_in_headers should apply to the first character as well

Maxim Dounin
March 25, 2014 12:16PM
Hello!

On Mon, Mar 24, 2014 at 04:48:29PM -0700, Piotr Sikora wrote:

> Hey Maxim,
>
> > - the "Parse:" prefix isn't something we use, it may be good idea
> > to avoid id;
>
> Done.
>
> > - please keep summary line short to avoid "hg log" wrapping, see
> > http://nginx.org/en/docs/contributing_changes.html;
>
> Done.
>
> > - is it something really needed in practice?
>
> Well, I'm not a fan of allowing underscores in the headers in the
> first place, but since this is already in nginx, I don't see a reason
> why this directive should allow underscores anywhere in the header
> name, but not in the first character...
>
> And yes, we have customers proxying headers starting with an underscore.

[...]

Committed, thanks.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Parse: underscores_in_headers should apply to the first character as well

Piotr Sikora 677 March 19, 2014 09:58PM

Re: [PATCH] Parse: underscores_in_headers should apply to the first character as well

Maxim Dounin 324 March 21, 2014 01:14PM

Re: [PATCH] Parse: underscores_in_headers should apply to the first character as well

Piotr Sikora 316 March 24, 2014 07:50PM

Re: [PATCH] Parse: underscores_in_headers should apply to the first character as well

Maxim Dounin 350 March 25, 2014 12:16PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 236
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready