Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Use ngx_socket_errno where appropriate.

Maxim Dounin
February 05, 2014 10:22AM
Hello!

On Wed, Feb 05, 2014 at 05:10:57PM +0400, Ruslan Ermilov wrote:

> On Mon, Feb 03, 2014 at 02:22:39PM -0800, Piotr Sikora wrote:
> > Hey,
> >
> > > Note that I still agree with Ruslan's comments to your patch, use
> > > of ngx_socket_errno to check errors from ioctl() / fcntl() in
> > > unix-specific code looks unneeded. And in case of eventfd - it
> > > looks certainly wrong, as eventfd isn't a socket.
> > >
> > > I would rather drop most of the src/os/unix changes, probably with
> > > the exception of ngx_tcp_nopush() checks.
> >
> > Done.
>
> Your latest patch looks good to me.

Same here. Committed, thanks.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Use ngx_socket_errno where appropriate.

Piotr Sikora 1161 January 30, 2014 07:18PM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Ruslan Ermilov 737 January 30, 2014 11:36PM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Igor Sysoev 910 January 31, 2014 12:40AM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Maxim Dounin 1138 January 31, 2014 06:40AM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Piotr Sikora 434 January 31, 2014 03:54PM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Maxim Dounin 344 February 04, 2014 09:34AM

Re: [PATCH] Use ngx_socket_errno where appropriate. Attachments

Piotr Sikora 526 February 04, 2014 09:34AM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Ruslan Ermilov 385 February 05, 2014 08:12AM

Re: [PATCH] Use ngx_socket_errno where appropriate.

Maxim Dounin 397 February 05, 2014 10:22AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 142
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready