Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Upstream: fix the cache duration calculation

Florent Le Coz
November 15, 2013 11:54AM
On 11/15/2013 05:44 PM, Maxim Dounin wrote:
>> I’ve set the priorities as: X-Accel-Expires > Cache-Control > Expires.
>> I’m not sure about what the priority of X-Accel-Expires should be
>> (but the last two are well defined in the RFC as you correctly
>> pointed in a previous message).
>
> That's certainly looks like an overkill. At most, we need just
> one bit to disambiguate the Cache-Control header processing, as it
> needs to know whether valid_sec was set by X-Accel-Expires (and
> then it shouldn't do anything) or by Expires (and then it's
> expected to override the value set).
>

In my next patch (using the Age header), we need to know if that value
was set by Cache-Control (and not by Expires or X-Accel-Expires),
because that’s the only case in which the valid_sec value should be
modified.
That would require a new bit to store this information.

> (A side note: we might also want to do something with u->cacheable
> set to 0 by Expires. The Expires header is expected to be
> overriden by Cache-Control, but it doesn't happen if an Expires
> header contained a date in the past and u->cacheable was set to 0
> due to it.)
>

Right.

--
Florent Le Coz
Smartjog

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Upstream: fix the cache duration calculation

Florent Le Coz 787 November 14, 2013 10:36AM

Re: [PATCH] Upstream: fix the cache duration calculation

Maxim Dounin 319 November 14, 2013 12:16PM

Re: [PATCH] Upstream: fix the cache duration calculation

Florent Le Coz 330 November 14, 2013 12:46PM

Re: [PATCH] Upstream: fix the cache duration calculation

Maxim Dounin 320 November 15, 2013 07:46AM

Re: [PATCH] Upstream: fix the cache duration calculation

Florent Le Coz 392 November 15, 2013 10:36AM

Re: [PATCH] Upstream: fix the cache duration calculation

Maxim Dounin 326 November 15, 2013 11:46AM

Re: [PATCH] Upstream: fix the cache duration calculation

Florent Le Coz 352 November 15, 2013 11:54AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 114
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready