Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Cache: gracefully exit the cache manager process

Maxim Dounin
November 04, 2013 07:08PM
Hello!

On Mon, Nov 04, 2013 at 02:07:23PM -0800, Yichun Zhang (agentzh) wrote:

> Hello!
>
> On Mon, Nov 4, 2013 at 1:31 PM, Maxim Dounin wrote:
> >
> > The cache manager process isn't worker process, so calling
> > ngx_worker_process_exit() looks strange.
> >
>
> But ngx_cache_manager_process_cycle() is already calling
> ngx_worker_process_init().

Yes, and this is known to cause problems. E.g., more than one
module was broken due to init_process callback being called in
cache manager/loader processes which are quite different from
worker processes.

> Are you suggesting removing this call as well?

No, but it is something we may consider.

In any case, I don't think that adding calls to worker-related
stuff is a good idea, at least without a thoughtful analysis of
possible side effects.

--
Maxim Dounin
http://nginx.org/en/donation.html

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Cache: gracefully exit the cache manager process

Yichun Zhang (agentzh) 916 November 04, 2013 03:58PM

Re: [PATCH] Cache: gracefully exit the cache manager process

Maxim Dounin 291 November 04, 2013 04:32PM

Re: [PATCH] Cache: gracefully exit the cache manager process

Yichun Zhang (agentzh) 271 November 04, 2013 05:08PM

Re: [PATCH] Cache: gracefully exit the cache manager process

Maxim Dounin 332 November 04, 2013 07:08PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 178
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready