Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh)
October 27, 2013 06:04PM
Hello!

On Sun, Oct 27, 2013 at 4:14 AM, Maxim Dounin wrote:
>> ctx->nomem = 0;
>> +
>> + if (in == NULL) {
>> + return rc;
>> + }
>> }
>>
>> for ( ;; ) {
>
> If there are pending data in ctx->in, they won't be handled.
>

Thank you for the catch! Updated my patch accordingly:

--- nginx-1.4.3/src/http/modules/ngx_http_gzip_filter_module.c
2013-10-08 05:07:14.000000000 -0700
+++ nginx-1.4.3-patched/src/http/modules/ngx_http_gzip_filter_module.c
2013-10-27 14:53:49.723406912 -0700
@@ -370,7 +370,7 @@ ngx_http_gzip_body_filter(ngx_http_reque
}
}

- if (ctx->nomem) {
+ if (ctx->nomem || in == NULL) {

/* flush busy buffers */
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh) 866 October 25, 2013 08:18PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Maxim Dounin 377 October 25, 2013 09:50PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh) 366 October 26, 2013 01:56AM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh) 403 October 26, 2013 02:00AM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Maxim Dounin 294 October 26, 2013 05:42PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh) 322 October 26, 2013 08:18PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Maxim Dounin 343 October 27, 2013 07:16AM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Maxim Dounin 368 October 27, 2013 10:08AM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh) 308 October 27, 2013 06:04PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Maxim Dounin 294 October 28, 2013 05:04PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Yichun Zhang (agentzh) 406 October 28, 2013 06:40PM

Re: [PATCH] ngx_gzip might hang the request for slow downstreams

Maxim Dounin 420 October 30, 2013 08:08PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 127
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready