Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Maxim Dounin
October 30, 2013 08:06PM
Hello!

On Mon, Oct 28, 2013 at 02:16:48PM -0700, Piotr Sikora wrote:

> Hey Maxim,
>
> > Ok, fair enough. Wouldn't something like this be better then
> > (untested)?
>
> It would, originally I had pretty much the same patch, but for some
> reason I thought you'd like the one I send better.
>
> Tested and works fine.
>
> > --- a/src/os/unix/ngx_errno.h
> > +++ b/src/os/unix/ngx_errno.h
> > @@ -51,6 +51,7 @@ typedef int ngx_err_t;
> > #define NGX_ENOMOREFILES 0
> > #define NGX_ELOOP ELOOP
> > #define NGX_EBADF EBADF
> > +#define NGX_EOPNOTSUPP EOPNOTSUPP
>
> Just a nitpick, but I believe that NGX_EOPNOTSUPP should be added
> between NGX_EINPROGRESS & NGX_EADDRINUSE, to keep the order the same
> as in system's errno.h.

Sure, fixed (and added win32 define for completeness). Committed,
thanks.

--
Maxim Dounin
http://nginx.org/en/donation.html

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Piotr Sikora 987 October 24, 2013 05:24PM

Re: [PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Maxim Dounin 369 October 25, 2013 02:18PM

Re: [PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Piotr Sikora 365 October 25, 2013 06:58PM

Re: [PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Maxim Dounin 334 October 25, 2013 11:32PM

Re: [PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Piotr Sikora 359 October 28, 2013 05:18PM

Re: [PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Maxim Dounin 431 October 30, 2013 08:06PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 150
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready