Welcome! Log In Create A New Profile

Advanced

Re: a little bug in ngx_event_expire_timers

Ruslan Ermilov
July 20, 2012 02:08AM
On Fri, Jul 20, 2012 at 12:11:51PM +0800, Joy zhou wrote:
> hi everyone:
>   
>   I have found a little bug at method ngx_event_expire_timers  of  the
> file "src/event/ngx_event_timer.c "
>   
>   
>      84     for ( ;; ) {
>      85
>      86         ngx_mutex_lock(ngx_event_timer_mutex);
>      87
>      88         root = ngx_event_timer_rbtree.root;
>      89
>      90         if (root == sentinel) {
>      91             return;
>      92         }
>     
>                [...]
>             }
>             
>    The above code should add 
> "ngx_mutex_unlock(ngx_event_timer_mutex);" at 90 line,
>    Because the ngx_event_timer_mutex has locked at begin , but returned
> without unlock , is it right?       

Only theoretically. Practically, ngx_mutex_lock() is a no-op in nginx.

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

a little bug in ngx_event_expire_timers

Joy zhou 1061 July 20, 2012 12:14AM

Re: a little bug in ngx_event_expire_timers

Ruslan Ermilov 387 July 20, 2012 02:08AM

Re: a little bug in ngx_event_expire_timers

Pass86 528 July 20, 2012 06:36AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 176
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready