Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] ngx_http_upstream state machine fixes

Maxim Dounin
March 31, 2012 10:50AM
Hello!

On Fri, Mar 30, 2012 at 02:50:48PM +0200, Piotr Sikora wrote:

> Hi,
>
> >The major question seems to be "what should be done if we've not
> >yet sent full request, but already got response"? Right now line
> >is drawn at "if we've got response header, we stop sending
> >request". And if we move the line - we should clearly understand
> >where the new line is and why.
>
> While current approach seems acceptable for single request-response
> connections, I'm pretty sure that it can be source of corruption for
> keepalived connections (in case when
> backend doesn't read rest of the request after sending response or
> when backend wants to read rest of the request that wasn't
> completely sent).
>
> I see two possible solutions: either kill connection after such
> "incomplete" request is made or make sure to send whole request even
> if we receive response while doing so.
>
> Opinions?

I tend to think that connection should be closed in this case.
And it's actually likely to be closed by an upstream server
anyway.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] ngx_http_upstream state machine fixes Attachments

agentzh 1365 March 21, 2012 09:44AM

Re: [PATCH] ngx_http_upstream state machine fixes

Maxim Dounin 543 March 21, 2012 11:40AM

Re: [PATCH] ngx_http_upstream state machine fixes

Piotr Sikora 436 March 30, 2012 08:52AM

Re: [PATCH] ngx_http_upstream state machine fixes

Maxim Dounin 516 March 31, 2012 10:50AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 181
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready