Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Fix logging keepalive related variables bug

Maxim Dounin
February 23, 2012 11:34PM
Hello!

On Thu, Feb 23, 2012 at 03:21:05PM +0800, Joshua Zhu wrote:

> Hi,
>
> On Mon, Feb 13, 2012 at 3:08 PM, Joshua Zhu <zhuzhaoyuan@gmail.com> wrote:
> > Hi,
> >
> > A bug was introduced in revision 3181 that r->keepalive was set to 0
> > before calling ngx_http_log_reques(), so the $sent_http_connection and
> > $sent_http_keep_alive variables will not work anymore.
>
> Could someone please review this patch?

It's flagged in my mailbox. There is nothing wrong with the
patch, but I tend to think that original r3181 is wrong and should
be just reverted (or redone properly if it tries to address some
valid problem). I've tried to ask Igor about it but he doesn't
remember details, so it waits for detailed invesigation.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Fix logging keepalive related variables bug

Joshua Zhu 1826 February 13, 2012 02:10AM

Re: [PATCH] Fix logging keepalive related variables bug

Joshua Zhu 483 February 23, 2012 02:22AM

Re: [PATCH] Fix logging keepalive related variables bug

Maxim Dounin 598 February 23, 2012 11:34PM

Re: [PATCH] Fix logging keepalive related variables bug

agentzh 475 June 20, 2012 10:56PM

Re: [PATCH] Fix logging keepalive related variables bug

Maxim Dounin 547 June 21, 2012 01:10PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 241
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready