Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] upstream process header data

Maxim Dounin
February 09, 2012 06:14AM
Hello!

On Thu, Feb 09, 2012 at 05:43:19PM +0800, 李飞勃 wrote:

> hello,
>
> I encountered a problem when I write a upstream module to process
> data from my upstream server.
> I set the header recv buffer to a small size that can not hold the
> whole response header. While in my process_header handler of my
> module, it will wait for the whole response header to process header,
> then return NGX_AGAIN and leave data in u->buffer not processed(in
> this case, u->buffer->pos < u->buffer->last). Then u->buffer->pos will
> never equal to u->buffer->end, and nginx will nerver log "upstream
> send too big header". This will cause nginx to call recv again with
> zero buffer size.
> I think this may be a problem, and I made a patch for that.

Looks like valid problem and correct patch for me. In vanilla
nginx this currently affects at least memcached module. If
memcached_buffer set to low value, it causes

[error] ... upstream prematurely closed connection while reading
response header from upstream ...

to be logged instead of correct

[error] ... upstream sent too big header while reading response
header from upstream ...

Could you please provide English transcription of your name you
would like to see in CHANGES? Is "Li Feibo" looks ok?

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] upstream process header data Attachments

李飞勃 1679 February 09, 2012 04:44AM

Re: [PATCH] upstream process header data

Maxim Dounin 481 February 09, 2012 06:14AM

Re: [PATCH] upstream process header data

李飞勃 491 February 09, 2012 08:58PM

Re: [PATCH] upstream process header data

Maxim Dounin 676 February 10, 2012 09:34AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 281
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready