Welcome! Log In Create A New Profile

Advanced

[PATCH 14 of 25] Mail: handle smtp multiline replies

Maxim Dounin
September 06, 2011 12:12PM
# HG changeset patch
# User Maxim Dounin <mdounin@mdounin.ru>
# Date 1315324516 -14400
# Node ID 28b35237ca588d407cbdd17d9535aa72ba589cff
# Parent e4da5e68a62f423479785add85c341f832811222
Mail: handle smtp multiline replies.

See here for details:

http://nginx.org/pipermail/nginx/2010-August/021713.html
http://nginx.org/pipermail/nginx/2010-August/021784.html
http://nginx.org/pipermail/nginx/2010-August/021785.html

diff --git a/src/mail/ngx_mail_proxy_module.c b/src/mail/ngx_mail_proxy_module.c
--- a/src/mail/ngx_mail_proxy_module.c
+++ b/src/mail/ngx_mail_proxy_module.c
@@ -701,7 +701,7 @@ ngx_mail_proxy_dummy_handler(ngx_event_t
static ngx_int_t
ngx_mail_proxy_read_response(ngx_mail_session_t *s, ngx_uint_t state)
{
- u_char *p;
+ u_char *p, *m;
ssize_t n;
ngx_buf_t *b;
ngx_mail_proxy_conf_t *pcf;
@@ -778,6 +778,25 @@ ngx_mail_proxy_read_response(ngx_mail_se
break;

default: /* NGX_MAIL_SMTP_PROTOCOL */
+
+ if (p[3] == '-') {
+ /* multiline reply, check if we got last line */
+
+ m = b->last - (sizeof(CRLF "200" CRLF) - 1);
+
+ while (m > p) {
+ if (m[0] == CR && m[1] == LF) {
+ break;
+ }
+
+ m--;
+ }
+
+ if (m <= p || m[5] == '-') {
+ return NGX_AGAIN;
+ }
+ }
+
switch (state) {

case ngx_smtp_start:

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 00 of 25] generic patch queue

Maxim Dounin 1699 September 06, 2011 12:10PM

[PATCH 01 of 25] Handling of If-Range with add_header Last-Modified

Maxim Dounin 716 September 06, 2011 12:10PM

[PATCH 02 of 25] Fix for incorrect 201 replies from dav module

Maxim Dounin 727 September 06, 2011 12:10PM

[PATCH 03 of 25] Fix for double content when return is used in error_page handler

Maxim Dounin 696 September 06, 2011 12:10PM

[PATCH 04 of 25] Fix for "return 202" not discarding body

Maxim Dounin 685 September 06, 2011 12:10PM

[PATCH 05 of 25] Incorrect special case for "return 204" removed

Maxim Dounin 678 September 06, 2011 12:10PM

[PATCH 06 of 25] Clear old Location header (if any) while adding new one

Maxim Dounin 735 September 06, 2011 12:10PM

[PATCH 07 of 25] Better handling of late upstream creation

Maxim Dounin 778 September 06, 2011 12:10PM

[PATCH 08 of 25] Gzip filter: handle empty flush buffers

Maxim Dounin 751 September 06, 2011 12:12PM

[PATCH 09 of 25] Fix for connection drops with AIO

Maxim Dounin 687 September 06, 2011 12:12PM

[PATCH 10 of 25] Fix for socket leak with "aio sendfile" and "limit_rate"

Maxim Dounin 749 September 06, 2011 12:12PM

[PATCH 11 of 25] Handling of Content-Encoding set from perl

Maxim Dounin 710 September 06, 2011 12:12PM

[PATCH 12 of 25] Gzip static: "always" parameter in "gzip_static" directive

Maxim Dounin 687 September 06, 2011 12:12PM

[PATCH 13 of 25] Memcached: memcached_gzip_flag directive

Maxim Dounin 806 September 06, 2011 12:12PM

[PATCH 14 of 25] Mail: handle smtp multiline replies

Maxim Dounin 643 September 06, 2011 12:12PM

[PATCH 15 of 25] Additional headers for proxy_ignore_headers/fastcgi_ignore_headers

Maxim Dounin 727 September 06, 2011 12:12PM

[PATCH 16 of 25] Fix for proxy_store leaving temporary files for subrequests

Maxim Dounin 770 September 06, 2011 12:12PM

[PATCH 17 of 25] Cache: fix for sending of empty responses

Maxim Dounin 657 September 06, 2011 12:12PM

[PATCH 18 of 25] Cache: fix for sending of stale responses

Maxim Dounin 808 September 06, 2011 12:14PM

[PATCH 19 of 25] Variables: honor no_cacheable for not_found variables

Maxim Dounin 790 September 06, 2011 12:14PM

[PATCH 20 of 25] Core: protection from subrequest loops

Maxim Dounin 693 September 06, 2011 12:14PM

[PATCH 21 of 25] Core: protection from cycles with named locations and post_action

Maxim Dounin 716 September 06, 2011 12:14PM

[PATCH 22 of 25] Autoindex: escape '?' in file names

Maxim Dounin 794 September 06, 2011 12:14PM

[PATCH 23 of 25] Autoindex: escape html in file names

Maxim Dounin 787 September 06, 2011 12:14PM

[PATCH 24 of 25] Unbreak build with embedded perl and --with-openssl

Maxim Dounin 828 September 06, 2011 12:14PM

[PATCH 25 of 25] Time parsing cleanup

Maxim Dounin 787 September 06, 2011 12:14PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 217
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready