Welcome! Log In Create A New Profile

Re: [Patch] Make resolver port configurable

Forum List Message List New Topic Print View

Maxim Dounin

February 14, 2011 04:16PM

Hello!

On Mon, Feb 14, 2011 at 03:53:47PM -0500, Sirsiwal, Umesh wrote:

> Thanks for the feedback. Here is update patch. This does not
> need a second parameter. Just allows host:port based
> configuration.

Just my 2 cents:

1. You may want to follow style to make all of us happy.

2. Using ngx_parse_url() instead of reinventing the wheel is a
good idea.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[Patch] Make resolver port configurable	Sirsiwal, Umesh	2286	February 10, 2011 10:20PM
Re: [Patch] Make resolver port configurable	Igor Sysoev	900	February 11, 2011 02:50AM
RE: [Patch] Make resolver port configurable	Sirsiwal, Umesh	752	February 14, 2011 03:56PM
Re: [Patch] Make resolver port configurable	Maxim Dounin	707	February 14, 2011 04:16PM
RE: [Patch] Make resolver port configurable	Sirsiwal, Umesh	1054	February 14, 2011 04:28PM