Welcome! Log In Create A New Profile

Advanced

Re: Nginx 1.1.9 Linux AIO segfault

Maxim Dounin
November 29, 2011 09:40AM
Hello!

On Tue, Nov 29, 2011 at 06:03:43AM -0500, INF[SZ] wrote:

> Игорь, вот 4 гига core dump меньше чем за
> минуту http://centos.alt.ru/pub/temp/nginx/core/
>
> Проблема 100% повторяема при
> одновременном наличии двух опций в
> одной локации
>
> 1. aio on;
> 2. directio 512;
>
> Пример
>
> location /repository {
> root /var/ftp/pub;
> autoindex on;
> aio on;
> directio 256;
> }
>
>
> В Nginx 1.1.8 проблема отсутствует.

Патч прилагается.

Maxim Dounin
# HG changeset patch
# User Maxim Dounin <mdounin@mdounin.ru>
# Date 1322577234 -10800
# Node ID 22cdd4c1a352f25fa3c5a2ece4f1613da5cf815b
# Parent 583a3cd2773c95a8741a8e5c15f1afc61307b87e
Fixed AIO on Linux, broken in r4306.

Events from eventfd do not have c->write set, and the stale event
check added in r4306 causes null pointer dereference.

diff --git a/src/event/modules/ngx_epoll_module.c b/src/event/modules/ngx_epoll_module.c
--- a/src/event/modules/ngx_epoll_module.c
+++ b/src/event/modules/ngx_epoll_module.c
@@ -681,19 +681,19 @@ ngx_epoll_process_events(ngx_cycle_t *cy

wev = c->write;

- if (c->fd == -1 || wev->instance != instance) {
+ if ((revents & EPOLLOUT) && wev->active) {

- /*
- * the stale event from a file descriptor
- * that was just closed in this iteration
- */
+ if (c->fd == -1 || wev->instance != instance) {

- ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
- "epoll: stale event %p", c);
- continue;
- }
+ /*
+ * the stale event from a file descriptor
+ * that was just closed in this iteration
+ */

- if ((revents & EPOLLOUT) && wev->active) {
+ ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
+ "epoll: stale event %p", c);
+ continue;
+ }

if (flags & NGX_POST_THREAD_EVENTS) {
wev->posted_ready = 1;
_______________________________________________
nginx-ru mailing list
nginx-ru@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-ru
Subject Author Posted

Nginx 1.1.9 Linux AIO segfault

INF[SZ] November 28, 2011 11:59PM

Re: Nginx 1.1.9 Linux AIO segfault

Igor Sysoev November 29, 2011 02:20AM

Re: Nginx 1.1.9 Linux AIO segfault

INF[SZ] November 29, 2011 06:03AM

Re: Nginx 1.1.9 Linux AIO segfault

Maxim Dounin November 29, 2011 09:40AM

Re: Nginx 1.1.9 Linux AIO segfault

INF[SZ] November 29, 2011 07:32PM

Re: Nginx 1.1.9 Linux AIO segfault

Maxim Dounin November 30, 2011 06:16AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 218
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready