All files from this thread

File Name	File Size		Posted by	Date
nginx-0.8.51-1.fc13.omega13a.src.rpm	662.5 KB	open | download	Brandon Amaro	09/27/2010	Read message

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

On 2010/09/27 06:41, Igor Sysoev wrote:
> *) Feature: now a listen socket "ssl" parameter may be set several
> times.

It seems that when one have both HTTP and HTTPS service under the same
host name, the HTTP service would break (asking for SSL certificate, log
says: no "ssl_certificate" is defined in server listening on SSL port
while SSL handshaking, client: 67.195.111.174, server: 0.0.0.0:80).

I think it is a bug, the problem is that when SSL support is compiled
in, all HTTP servers would be considered as SSL since their opt.set is 1.

Attached patch should fix the problem (I am not very familiar with the
code though).

Thanks for your work on nginx! :)

Cheers,
- --
Xin LI <delphij@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)

iQEcBAEBCAAGBQJMoUtNAAoJEATO+BI/yjfBgWkIAIGzkjoFuS7Ig42GZSfT1rhU
8ZyryQLNVWMBXXhoEdV4sd/eu9hLOn19nc+bO8xr/KJUwTJOD5x3MsX/OWxf7X2Q
pKdNhvkEYL7XhdZNydjgH44MWBEx49dHQMB1N7W0SIZyNZQ2ylI1M0+YF+tlE9cl
5glOPUKsLnv77gNq2dU5RVUt5b1ihPxEZ3SXdwVnxZgp4tfnZmczc16rFbsZpjfB
WCaGGhM19wcwAV6j1hPbO09Ror4Q7m5ebuszpi49JhSBE5WEiTLrSuFMwHA4rA0E
Nz1eB8I/j+DL2iXGJP/Tzl9TUDfhiZ3Xv1BIG1pyXGbDY4rjahW/KRUa/wZiCNA=
=pXjW
-----END PGP SIGNATURE-----
--- src/http/ngx_http.c.orig 2010-09-27 04:48:12.000000000 -0700
+++ src/http/ngx_http.c 2010-09-27 18:46:32.820822332 -0700
@@ -1274,7 +1274,7 @@
default_server = addr[i].opt.default_server;

#if (NGX_HTTP_SSL)
- ssl = lsopt->ssl || addr[i].opt.set;
+ ssl = lsopt->ssl && addr[i].opt.set;
#endif

if (lsopt->set) {
_______________________________________________
nginx mailing list
nginx@nginx.org
http://nginx.org/mailman/listinfo/nginx