Welcome! Log In Create A New Profile

Advanced

"make install" of php-fpm-0.6 overwrites "/etc/php-fpm.conf" and "/etc/init.d/php-fpm"

Posted by Martin 
All files from this thread

File Name File Size   Posted by Date  
fpm-rev-93-make-install.patch 16.1 KB open | download dreamcat4 10/09/2009 Read message
fpm-rev-93-make-install-2.patch 18.3 KB open | download dreamcat4 10/10/2009 Read message
patch-update-1-2.diff 7.6 KB open | download dreamcat4 10/10/2009 Read message
On Sat, Oct 10, 2009 at 2:03 PM, Juan Fco. Giordana
<juangiordana@gmail.com> wrote:
> Although, even better (IMO), just leave those files in the source code
> directory and provide instruction in the docs to proceed in a way similar to
> [1]:
>
> [...]
> make install
> install -v -m644 php-fpm.conf /etc/php-fpm.conf
> install -v -m755 php-fpm.init /etc/init.d/php-fpm

This is somewhat better idea. However you can't please everybody and
its pretty obvious if we did that we'd just constantly having people
reporting that php-fpm daemon won't start (or restart, shutdown)
because theres no configuration file or init script.

> Probably having this as part of the installation docs gives more flexibility
> to the person that is trying to install the package or prepare the package
> for use on a distribution and on the other hand it makes the package
> maintainer less things to worry about.

Or just type ./configure --help and everything can be chosen in the
configure flags. This style is definitely way much closer to the style
of the official php. If you see inside the patch file, you'll notice
there *are* new and better explanatory notes provided now. These
should be enough help for any package maintainer. You kinda make it
feel like the package maintainers are the ones who are less
knowledgeable and need this extra assistance. But its generally the
other way round and the people who are new to unix are the ones who
will need the much more help. These are also the group who would
rather not do this:

> install -v -m644 php-fpm.conf /etc/php-fpm.conf
> install -v -m755 php-fpm.init /etc/init.d/php-fpm

Actually to exclude those files by default is just asking for trouble.
OTOH, if a user has installed them in error, its pretty harmless,
innocuus. And for the case with upgrading /etc/php-fpm.conf which
overwrites the previous config file: This is also solved now
automatically. See the new patch file (and explanatory notes changes).


Best regards,

dreamcat4
dreamcat4@gmail.com
Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 108
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready