Hello!

On 2024-05-20, Sergey Kandaurov wrote:
> Concerning type compatibility, C11 gives a definition on what types
> are compatible. [...]

Thank-you for sharing these findings!

> I like the patch, but would like to adjust the commit log:
> there some styles issues and over-quoting. Also, there is
> no mention of Clang behaviour. Please see below.
>
> # HG changeset patch
> # User Edgar Bonet <bonet@grenoble.cnrs.fr>
> # Date 1715850910 -7200
> # Thu May 16 11:15:10 2024 +0200
> # Node ID 8d35d9cfef17f350f750049940e22d1d61d55a6a
> # Parent 5a5c01ec6f58d413e9867ace5d0065bb43484a11
> Configure: fixed building libatomic test.
>
> Using "long *" instead of "AO_t *" leads either to -Wincompatible-pointer-types
> or -Wpointer-sign warnings, depending on whether long and size_t are compatible
> types (e.g., ILP32 versus LP64 data models). Notably, -Wpointer-sign warnings
> are enabled by default in Clang only, and -Wincompatible-pointer-types is an
> error starting from GCC 14.
>
> Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>

This all looks good to me.

Regards,

Edgar.
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel