Welcome! Log In Create A New Profile

Re: [PATCH 3 of 3] Modules compatibility: added QUIC to signature (ticket #2539)

Forum List Message List New Topic Print View

Roman Arutyunyan

September 13, 2023 12:08PM

Hi,

On Tue, Sep 12, 2023 at 05:05:35PM +0400, Sergey Kandaurov wrote:
>
> > On 11 Sep 2023, at 15:30, Roman Arutyunyan <arut@nginx.com> wrote:
> >
> > # HG changeset patch
> > # User Roman Arutyunyan <arut@nginx.com>
> > # Date 1694088909 -14400
> > # Thu Sep 07 16:15:09 2023 +0400
> > # Node ID 766e9a5771e20cdb3ec41b8001b065ee299ec7ea
> > # Parent 9ee4158b9d3fa41e647b772e707c29b3e4cb77b5
> > Modules compatibility: added QUIC to signature (ticket #2539).
> >
> > Enabling QUIC changes ngx_connection_t layout, which is why it should be
> > added to the signature.
> >
>
> There are several spare values, such as NGX_MODULE_SIGNATURE_9,
> unused since initial dynamic modules support in 85dea406e18f.
> They could be reused without introducing more signature points.

Thanks. I'm choosing #18 unused since 2016.

> > diff --git a/src/core/ngx_module.h b/src/core/ngx_module.h
> > --- a/src/core/ngx_module.h
> > +++ b/src/core/ngx_module.h
> > @@ -191,12 +191,18 @@
> > #define NGX_MODULE_SIGNATURE_33 "0"
> > #endif
> >
> > -#if (NGX_COMPAT)
> > +#if (NGX_QUIC || NGX_COMPAT)
> > #define NGX_MODULE_SIGNATURE_34 "1"
> > #else
> > #define NGX_MODULE_SIGNATURE_34 "0"
> > #endif
> >
> > +#if (NGX_COMPAT)
> > +#define NGX_MODULE_SIGNATURE_35 "1"
> > +#else
> > +#define NGX_MODULE_SIGNATURE_35 "0"
> > +#endif
> > +
> > #define NGX_MODULE_SIGNATURE \
> > NGX_MODULE_SIGNATURE_0 NGX_MODULE_SIGNATURE_1 NGX_MODULE_SIGNATURE_2 \
> > NGX_MODULE_SIGNATURE_3 NGX_MODULE_SIGNATURE_4 NGX_MODULE_SIGNATURE_5 \
> > @@ -209,7 +215,7 @@
> > NGX_MODULE_SIGNATURE_24 NGX_MODULE_SIGNATURE_25 NGX_MODULE_SIGNATURE_26 \
> > NGX_MODULE_SIGNATURE_27 NGX_MODULE_SIGNATURE_28 NGX_MODULE_SIGNATURE_29 \
> > NGX_MODULE_SIGNATURE_30 NGX_MODULE_SIGNATURE_31 NGX_MODULE_SIGNATURE_32 \
> > - NGX_MODULE_SIGNATURE_33 NGX_MODULE_SIGNATURE_34
> > + NGX_MODULE_SIGNATURE_33 NGX_MODULE_SIGNATURE_34 NGX_MODULE_SIGNATURE_35
> >
> >
> > #define NGX_MODULE_V1 \
>
> --
> Sergey Kandaurov
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> https://mailman.nginx.org/mailman/listinfo/nginx-devel

--
Roman Arutyunyan
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[PATCH 0 of 3] QUIC module compatibility issues	Roman Arutyunyan	406	September 11, 2023 07:32AM
[PATCH 1 of 3] QUIC: "handshake_timeout" configuration parameter	Roman Arutyunyan	104	September 11, 2023 07:32AM
Re: [PATCH 1 of 3] QUIC: "handshake_timeout" configuration parameter	Sergey Kandaurov	105	September 12, 2023 09:06AM
Re: [PATCH 1 of 3] QUIC: "handshake_timeout" configuration parameter	Roman Arutyunyan	105	September 13, 2023 11:56AM
[PATCH 2 of 3] HTTP/3: eliminated v3_session field from ngx_http_connection_t	Roman Arutyunyan	109	September 11, 2023 07:32AM
Re: [PATCH 2 of 3] HTTP/3: eliminated v3_session field from ngx_http_connection_t	Sergey Kandaurov	103	September 12, 2023 09:06AM
Re: [PATCH 2 of 3] HTTP/3: eliminated v3_session field from ngx_http_connection_t	Roman Arutyunyan	106	September 13, 2023 12:04PM
[PATCH 3 of 3] Modules compatibility: added QUIC to signature (ticket #2539)	Roman Arutyunyan	103	September 11, 2023 07:32AM
Re: [PATCH 3 of 3] Modules compatibility: added QUIC to signature (ticket #2539)	Sergey Kandaurov	117	September 12, 2023 09:06AM
Re: [PATCH 3 of 3] Modules compatibility: added QUIC to signature (ticket #2539)	Roman Arutyunyan	105	September 13, 2023 12:08PM
[PATCH 0 of 6] QUIC module compatibility issues	Roman Arutyunyan	132	September 14, 2023 06:18AM
[PATCH 1 of 6] QUIC: "handshake_timeout" configuration parameter	Roman Arutyunyan	135	September 14, 2023 06:18AM
[PATCH 2 of 6] HTTP/3: moved variable initialization	Roman Arutyunyan	119	September 14, 2023 06:18AM
[PATCH 3 of 6] QUIC: call shutdown() callback only after handshake completion	Roman Arutyunyan	109	September 14, 2023 06:18AM
Re: [PATCH 3 of 6] QUIC: call shutdown() callback only after handshake completion	Sergey Kandaurov	108	September 19, 2023 06:00AM
Re: [PATCH 3 of 6] QUIC: call shutdown() callback only after handshake completion	Sergey Kandaurov	122	September 19, 2023 06:34AM
Re: [PATCH 3 of 6] QUIC: call shutdown() callback only after handshake completion	Roman Arutyunyan	114	September 21, 2023 11:42AM
Re: [PATCH 3 of 6] QUIC: call shutdown() callback only after handshake completion	Sergey Kandaurov	120	September 22, 2023 07:24AM
[PATCH 4 of 6] HTTP/3: postponed session creation to init() callback	Roman Arutyunyan	110	September 14, 2023 06:18AM
[PATCH 5 of 6] QUIC: simplified setting close timer when closing connection	Roman Arutyunyan	107	September 14, 2023 06:18AM
[PATCH 6 of 6] Modules compatibility: added QUIC to signature (ticket #2539)	Roman Arutyunyan	101	September 14, 2023 06:18AM

Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 217

Record Number of Users: 8 on April 13, 2023

Record Number of Guests: 500 on July 15, 2024