Welcome! Log In Create A New Profile

Advanced

[PATCH 2 of 4] QUIC: always add ACK frame to the queue head

Roman Arutyunyan
July 27, 2023 08:44AM
# HG changeset patch
# User Roman Arutyunyan <arut@nginx.com>
# Date 1690461509 -14400
# Thu Jul 27 16:38:29 2023 +0400
# Node ID 0d12ada84c168c62e9bae847af2725641da583d0
# Parent 2fd16fc76920ef0b8ea2fa64858934e38c4477c5
QUIC: always add ACK frame to the queue head.

Previously it was added to the tail as all other frames. However, if the
amount of queued data is large, it could delay the delivery of ACK, which
could trigger frames retransmissions and slow down the connection.

diff --git a/src/event/quic/ngx_event_quic_output.c b/src/event/quic/ngx_event_quic_output.c
--- a/src/event/quic/ngx_event_quic_output.c
+++ b/src/event/quic/ngx_event_quic_output.c
@@ -1175,7 +1175,9 @@ ngx_quic_send_ack(ngx_connection_t *c, n
frame->u.ack.range_count = ctx->nranges;
frame->u.ack.first_range = ctx->first_range;

- ngx_quic_queue_frame(qc, frame);
+ ngx_queue_insert_head(&ctx->frames, &frame->queue);
+
+ frame->len = ngx_quic_create_frame(NULL, frame);

return NGX_OK;
}
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 0 of 4] QUIC performance optimizations

Roman Arutyunyan 291 July 27, 2023 08:44AM

[PATCH 1 of 4] QUIC: optimized ACK delay

Roman Arutyunyan 80 July 27, 2023 08:44AM

Re: [PATCH 1 of 4] QUIC: optimized ACK delay

Sergey Kandaurov 58 August 10, 2023 11:50AM

[PATCH 2 of 4] QUIC: always add ACK frame to the queue head

Roman Arutyunyan 82 July 27, 2023 08:44AM

Re: [PATCH 2 of 4] QUIC: always add ACK frame to the queue head

Sergey Kandaurov 68 August 10, 2023 12:04PM

Re: [PATCH 2 of 4] QUIC: always add ACK frame to the queue head

Vladimir Homutov via nginx-devel 66 August 10, 2023 12:28PM

Re: [PATCH 2 of 4] QUIC: always add ACK frame to the queue head

Sergey Kandaurov 82 August 10, 2023 12:38PM

[PATCH 3 of 4] QUIC: fixed congesion control in GSO mode

Roman Arutyunyan 72 July 27, 2023 08:44AM

Re: [PATCH 3 of 4] QUIC: fixed congesion control in GSO mode

Sergey Kandaurov 60 August 10, 2023 12:22PM

[PATCH 4 of 4] QUIC: use sendmmsg() with GSO

Roman Arutyunyan 71 July 27, 2023 08:44AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 137
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready