Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Configure: dump unsupported repository error and exit

Sergey Kandaurov
May 23, 2023 12:30PM
> On 23 May 2023, at 19:48, Roman Arutyunyan <arut@nginx.com> wrote:
>
> # HG changeset patch
> # User Roman Arutyunyan <arut@nginx.com>
> # Date 1684856745 -14400
> # Tue May 23 19:45:45 2023 +0400
> # Branch quic
> # Node ID bd25277d0ed77a90766bc2f4153538c86621cdfc
> # Parent a83071314a22652d4a552e72e13d18aa4c01d79e
> Configure: dump unsupported repository error and exit.
>
> diff --git a/auto/configure b/auto/configure
> --- a/auto/configure
> +++ b/auto/configure
> @@ -4,6 +4,13 @@
> # Copyright (C) Nginx, Inc.
>
>
> +cat << END
> +
> +$0: this repository is no longer supported, see README
> +
> +END
> +exit 1
> +
> LC_ALL=C
> export LC_ALL
>

Something similar to what we use for invalid options might be enough.
Also, using "error" might help emphasize this is an error:

diff --git a/auto/configure b/auto/configure
--- a/auto/configure
+++ b/auto/configure
@@ -4,6 +4,9 @@
# Copyright (C) Nginx, Inc.


+echo "$0: error: this repository is no longer supported, see README"
+exit 1
+
LC_ALL=C
export LC_ALL


Personally, I think this makes sense, in order to help break pipelines.

--
Sergey Kandaurov
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Configure: dump unsupported repository error and exit

Roman Arutyunyan 274 May 23, 2023 11:50AM

Re: [PATCH] Configure: dump unsupported repository error and exit

Sergey Kandaurov 98 May 23, 2023 12:30PM

Re: [PATCH] Configure: dump unsupported repository error and exit

Roman Arutyunyan 68 June 20, 2023 09:14AM

Re: [PATCH] Configure: dump unsupported repository error and exit

Sergey Kandaurov 89 June 20, 2023 09:24AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 268
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready