Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] QUIC: improved SO_COOKIE configure test

Maxim Dounin
January 24, 2023 10:20PM
Hello!

On Wed, Jan 25, 2023 at 12:22:54AM +0100, Alex Colomar wrote:

> On 1/23/23 03:59, Maxim Dounin wrote:
> > # HG changeset patch
> > # User Maxim Dounin <mdounin@mdounin.ru>
> > # Date 1674441584 -10800
> > # Mon Jan 23 05:39:44 2023 +0300
> > # Branch quic
> > # Node ID 849f3b4043ee07a65bbfc4ad136e4246002ec00c
> > # Parent 6bb884dc72916dc675df65d02abee0c9cfabc916
> > QUIC: improved SO_COOKIE configure test.
> >
> > In nginx source code the inttypes.h include, if available, is used to define
> > standard integer types. Changed the SO_COOKIE configure test to follow this.
>
> May I ask for curiosity why do you prefer <inttypes.h> for the standard
> integer types?
>
> Normally, the preferred header file is <stdint.h>, since it's smaller;
> unless you use the macros or functions from <inttypes.h>, which are
> things like PRId32, or imaxabs(3).
>
> Is there any portability issue with <stdint.h>?

The inttypes.h is more portable: for example, stdint.h is not
available on FreeBSD before FreeBSD 5.0:

https://github.com/freebsd/freebsd-src/commit/0ac2d551f20a8769869f61ebfe742fd55cef70b9

While this is not important for the particular test (since all
known Linux versions with SO_COOKIE do have stdint.h), using the
same header in all tests and the code is good from consistency
point of view.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] QUIC: improved SO_COOKIE configure test

Maxim Dounin 420 January 22, 2023 10:00PM

Re: [PATCH] QUIC: improved SO_COOKIE configure test

Roman Arutyunyan 125 January 23, 2023 07:30AM

Re: [PATCH] QUIC: improved SO_COOKIE configure test

Maxim Dounin 113 January 23, 2023 07:00PM

Re: [PATCH] QUIC: improved SO_COOKIE configure test

Alex Colomar 128 January 24, 2023 06:24PM

Re: [PATCH] QUIC: improved SO_COOKIE configure test

Maxim Dounin 116 January 24, 2023 10:20PM

Re: [PATCH] QUIC: improved SO_COOKIE configure test

Alex Colomar 167 January 25, 2023 04:20AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 234
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready