Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

Maxim Dounin
July 15, 2022 01:26AM
Hello!

On Thu, Jul 14, 2022 at 06:51:28PM +0100, Yaroslav Zhuravlev wrote:

> # User Yaroslav Zhuravlev <yar@nginx.com>
> # Date 1657820606 -3600
> # Thu Jul 14 18:43:26 2022 +0100
> # Node ID ef51bb5722334aea46d2846d7a30d671b0f624db
> # Parent 9172cf4d2713b685d6956810e5fcad4c29881637
> Documented the "ipv4=off" parameter of the "resolver" directive.
>
> diff --git a/xml/en/docs/http/ngx_http_core_module.xml b/xml/en/docs/http/ngx_http_core_module.xml
> --- a/xml/en/docs/http/ngx_http_core_module.xml
> +++ b/xml/en/docs/http/ngx_http_core_module.xml
> @@ -10,7 +10,7 @@
> <module name="Module ngx_http_core_module"
> link="/en/docs/http/ngx_http_core_module.html"
> lang="en"
> - rev="99">
> + rev="100">
>
> <section id="directives" name="Directives">
>
> @@ -2181,6 +2181,7 @@
> <value>address</value> ...
> [<literal>valid</literal>=<value>time</value>]
> [<literal>ipv6</literal>=<literal>on</literal>|<literal>off</literal>]
> + [<literal>ipv4</literal>=<literal>on</literal>|<literal>off</literal>]
> [<literal>status_zone</literal>=<value>zone</value>]</syntax>
> <default/>
> <context>http</context>
> @@ -2214,6 +2215,11 @@
> </note>
> </para>
>
> +<para id="resolver_ipv4">
> +If looking up of IPv4 addresses is not desired,
> +the <literal>ipv4=off</literal> parameter can be specified (1.23.1).
> +</para>

Shouldn't it be in the same paragraph which describes the default
behaviour ("both IPv4 and IPv6 addresses") and "ipv6=off"?

It might be also a good idea to describe "ipv6=off" and
"ipv4=off" in one sentence instead of repeating the same phrase
twice.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

Yaroslav Zhuravlev 363 July 14, 2022 01:54PM

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

Maxim Dounin 99 July 15, 2022 01:26AM

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

Yaroslav Zhuravlev 157 July 15, 2022 07:52AM

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

Yaroslav Zhuravlev 75 July 19, 2022 09:26AM

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

Maxim Dounin 116 July 19, 2022 09:50AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 272
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready