> On 18 Jun 2022, at 00:37, Maxim Dounin <mdounin@mdounin.ru> wrote:
>
> Hello!
>
> On Fri, Jun 17, 2022 at 07:31:27PM +0400, Sergey Kandaurov wrote:
>
>>> On 17 Jun 2022, at 01:33, Maxim Dounin <mdounin@mdounin.ru> wrote:
>>>
>>> # HG changeset patch
>>> # User Maxim Dounin <mdounin@mdounin.ru>
>>> # Date 1655415152 -10800
>>> # Fri Jun 17 00:32:32 2022 +0300
>>> # Node ID e23a385cd0ec866a3eb1d8c9c956991e1ed50d78
>>> # Parent 861f076eab72dab85bd5eaa56da770f8b10aa8ad
>>> Misc: win32 sources now preserved in release tarballs.
>>>
>>> This makes it possible to build nginx under Windows from release tarballs
>>> instead of using source code repository.
>>>
>>> diff --git a/misc/GNUmakefile b/misc/GNUmakefile
>>> --- a/misc/GNUmakefile
>>> +++ b/misc/GNUmakefile
>>> @@ -15,12 +15,6 @@ release: export
>>>
>>> mv $(TEMP)/$(NGINX)/auto/configure $(TEMP)/$(NGINX)
>>>
>>
>> Do we need the empty line here?
>> It could be collapsed if removing all the below.
>
> It clearly separates two distinct blocks: configure and docs. I
> don't think this distinction have to be removed.
>

Ok.

>>> - # delete incomplete sources
>>> - rm $(TEMP)/$(NGINX)/src/event/ngx_event_acceptex.c
>>> - rm $(TEMP)/$(NGINX)/src/event/ngx_event_connectex.c
>>
>> I wonder if we need to touch ngx_event_connectex.c.
>> It's not used nor connected to the build since introduction,
>> so it does look incomplete.
>
> I don't think it is a good idea to keep any of these removals,
> even if some files are not connected to the build. Rather, I
> think that release tarballs should be as close as possible to the
> source code repository.

Agreed, it makes sense.

>
> Just in case, ngx_service.c and ngx_stat.c in src/os/win32/ also
> not connected to the build.
>
>>> - rm $(TEMP)/$(NGINX)/src/event/modules/ngx_iocp_module.*
>>> - rm -r $(TEMP)/$(NGINX)/src/os/win32
>>> -
>>> mv $(TEMP)/$(NGINX)/docs/text/LICENSE $(TEMP)/$(NGINX)
>>> mv $(TEMP)/$(NGINX)/docs/text/README $(TEMP)/$(NGINX)
>>> mv $(TEMP)/$(NGINX)/docs/html $(TEMP)/$(NGINX)
>>>

--
Sergey Kandaurov

_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org