Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Upstream keepalive: remove extra SSL shutdown processing.

Maxim Dounin
May 12, 2022 06:10PM
Hello!

On Thu, May 12, 2022 at 05:36:33AM +0000, Pavel Pautov via nginx-devel wrote:

> Looks like, with both no_wait_shutdown and no_send_shutdown flags set, ngx_ssl_shutdown() is supposed to be synchronous.
> There is similar ngx_ssl_shutdown() usage in ngx_http_upstream_next().
>

> # HG changeset patch
> # User Pavel Pautov <p.pautov@f5.com>
> # Date 1652332850 25200
> # Wed May 11 22:20:50 2022 -0700
> # Node ID f9cca9c9a0aab58b4d16260c589a6142a1d52b95
> # Parent 35afae4b3dffff6718c0cab3ceb16b9de207c20a
> Upstream keepalive: remove extra SSL shutdown processing.
>
> diff --git a/src/http/modules/ngx_http_upstream_keepalive_module.c b/src/http/modules/ngx_http_upstream_keepalive_module.c
> --- a/src/http/modules/ngx_http_upstream_keepalive_module.c
> +++ b/src/http/modules/ngx_http_upstream_keepalive_module.c
> @@ -471,10 +471,7 @@ ngx_http_upstream_keepalive_close(ngx_co
> c->ssl->no_wait_shutdown = 1;
> c->ssl->no_send_shutdown = 1;
>
> - if (ngx_ssl_shutdown(c) == NGX_AGAIN) {
> - c->ssl->handler = ngx_http_upstream_keepalive_close;
> - return;
> - }
> + (void) ngx_ssl_shutdown(c);
> }
>
> #endif

No, thanks.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] Upstream keepalive: remove extra SSL shutdown processing. Attachments

Pavel Pautov via nginx-devel 362 May 12, 2022 01:40AM

Re: [PATCH] Upstream keepalive: remove extra SSL shutdown processing.

Maxim Dounin 100 May 12, 2022 06:10PM

RE: [PATCH] Upstream keepalive: remove extra SSL shutdown processing.

Pavel Pautov via nginx-devel 117 May 12, 2022 06:28PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 345
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready