Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin
May 02, 2022 04:12PM
Hello!

On Mon, May 02, 2022 at 08:41:40AM +0500, RekGRpth wrote:

> I think, my suggested in patch solution is more clear and easy and
> beauty, than using cleanup handler to save any connection-specific
> data within a cached connection.

To re-iterate:

- Your suggested patch does nothing for nginx itself where the
upstream module infrastructure is used by the upstream module,
and c->data points to the request, so saving it will just waste
resources. Your patch only makes sense for your module (which
is basically a hack by design).

- There is a proper way to do what you are trying to do, not
limited to your module. You are free to use it, much like other
modules do.

Hope this helps.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] upstream keepalive: save and restore connection data

RekGRpth 612 April 30, 2022 01:04AM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 108 April 30, 2022 06:20PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 200 April 30, 2022 10:48PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 140 May 01, 2022 11:56AM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 113 May 01, 2022 11:44PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 93 May 02, 2022 04:12PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 94 May 05, 2022 12:24AM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 146 May 05, 2022 05:38PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 108 May 05, 2022 11:40PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 106 May 06, 2022 09:30AM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 119 May 06, 2022 09:58AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 301
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready