Welcome! Log In Create A New Profile

Advanced

[nginx] Upstream: fixed logging level of upstream invalid header errors.

Maxim Dounin
October 18, 2021 09:50AM
details: https://hg.nginx.org/nginx/rev/2f443cac3f1e
branches:
changeset: 7933:2f443cac3f1e
user: Maxim Dounin <mdounin@mdounin.ru>
date: Mon Oct 18 16:46:59 2021 +0300
description:
Upstream: fixed logging level of upstream invalid header errors.

In b87b7092cedb (nginx 1.21.1), logging level of "upstream sent invalid
header" errors was accidentally changed to "info". This change restores
the "error" level, which is a proper logging level for upstream-side
errors.

diffstat:

src/http/modules/ngx_http_fastcgi_module.c | 2 +-
src/http/modules/ngx_http_proxy_module.c | 2 +-
src/http/modules/ngx_http_scgi_module.c | 2 +-
src/http/modules/ngx_http_uwsgi_module.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diffs (48 lines):

diff -r 01829d162095 -r 2f443cac3f1e src/http/modules/ngx_http_fastcgi_module.c
--- a/src/http/modules/ngx_http_fastcgi_module.c Tue Oct 12 23:18:18 2021 +0300
+++ b/src/http/modules/ngx_http_fastcgi_module.c Mon Oct 18 16:46:59 2021 +0300
@@ -2021,7 +2021,7 @@ ngx_http_fastcgi_process_header(ngx_http

/* rc == NGX_HTTP_PARSE_INVALID_HEADER */

- ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
+ ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"upstream sent invalid header: \"%*s\\x%02xd...\"",
r->header_end - r->header_name_start,
r->header_name_start, *r->header_end);
diff -r 01829d162095 -r 2f443cac3f1e src/http/modules/ngx_http_proxy_module.c
--- a/src/http/modules/ngx_http_proxy_module.c Tue Oct 12 23:18:18 2021 +0300
+++ b/src/http/modules/ngx_http_proxy_module.c Mon Oct 18 16:46:59 2021 +0300
@@ -2021,7 +2021,7 @@ ngx_http_proxy_process_header(ngx_http_r

/* rc == NGX_HTTP_PARSE_INVALID_HEADER */

- ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
+ ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"upstream sent invalid header: \"%*s\\x%02xd...\"",
r->header_end - r->header_name_start,
r->header_name_start, *r->header_end);
diff -r 01829d162095 -r 2f443cac3f1e src/http/modules/ngx_http_scgi_module.c
--- a/src/http/modules/ngx_http_scgi_module.c Tue Oct 12 23:18:18 2021 +0300
+++ b/src/http/modules/ngx_http_scgi_module.c Mon Oct 18 16:46:59 2021 +0300
@@ -1142,7 +1142,7 @@ ngx_http_scgi_process_header(ngx_http_re

/* rc == NGX_HTTP_PARSE_INVALID_HEADER */

- ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
+ ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"upstream sent invalid header: \"%*s\\x%02xd...\"",
r->header_end - r->header_name_start,
r->header_name_start, *r->header_end);
diff -r 01829d162095 -r 2f443cac3f1e src/http/modules/ngx_http_uwsgi_module.c
--- a/src/http/modules/ngx_http_uwsgi_module.c Tue Oct 12 23:18:18 2021 +0300
+++ b/src/http/modules/ngx_http_uwsgi_module.c Mon Oct 18 16:46:59 2021 +0300
@@ -1363,7 +1363,7 @@ ngx_http_uwsgi_process_header(ngx_http_r

/* rc == NGX_HTTP_PARSE_INVALID_HEADER */

- ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
+ ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"upstream sent invalid header: \"%*s\\x%02xd...\"",
r->header_end - r->header_name_start,
r->header_name_start, *r->header_end);
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[nginx] Upstream: fixed logging level of upstream invalid header errors.

Maxim Dounin 295 October 18, 2021 09:50AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 54
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready