Welcome! Log In Create A New Profile

Advanced

[PATCH 1 of 4] Switched to using posted next events after sendfile_max_chunk

Maxim Dounin
October 11, 2021 03:10PM
# HG changeset patch
# User Maxim Dounin <mdounin@mdounin.ru>
# Date 1633978533 -10800
# Mon Oct 11 21:55:33 2021 +0300
# Node ID d175cd09ac9d2bab7f7226eac3bfce196a296cc0
# Parent ae7c767aa491fa55d3168dfc028a22f43ac8cf89
Switched to using posted next events after sendfile_max_chunk.

Previously, 1 millisecond delay was used instead. In certain edge cases
this might result in noticeable performance degradation though, notably on
Linux with typical CONFIG_HZ=250 (so 1ms delay becomes 4ms),
sendfile_max_chunk 2m, and link speed above 2.5 Gbps.

Using posted next events removes the artificial delay and makes processing
fast in all cases.

diff --git a/src/http/ngx_http_write_filter_module.c b/src/http/ngx_http_write_filter_module.c
--- a/src/http/ngx_http_write_filter_module.c
+++ b/src/http/ngx_http_write_filter_module.c
@@ -331,8 +331,7 @@ ngx_http_write_filter(ngx_http_request_t
&& c->write->ready
&& c->sent - sent >= limit - (off_t) (2 * ngx_pagesize))
{
- c->write->delayed = 1;
- ngx_add_timer(c->write, 1);
+ ngx_post_event(c->write, &ngx_posted_next_events);
}

for (cl = r->out; cl && cl != chain; /* void */) {

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 1 of 4] Switched to using posted next events after sendfile_max_chunk

Maxim Dounin 195 October 11, 2021 03:10PM

Re: [PATCH 1 of 4] Switched to using posted next events after sendfile_max_chunk

Sergey Kandaurov 31 October 26, 2021 07:36AM

Re: [PATCH 1 of 4] Switched to using posted next events after sendfile_max_chunk

Maxim Dounin 36 October 26, 2021 11:28AM

Re: [PATCH 1 of 4] Switched to using posted next events after sendfile_max_chunk

Sergey Kandaurov 36 October 26, 2021 10:08AM

Re: [PATCH 1 of 4] Switched to using posted next events after sendfile_max_chunk

Maxim Dounin 43 October 26, 2021 11:52AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 74
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready