details: https://hg.nginx.org/nginx/rev/f302c1096f7b
branches:
changeset: 7909:f302c1096f7b
user: Maxim Dounin <mdounin@mdounin.ru>
date: Sun Aug 29 22:20:38 2021 +0300
description:
HTTP/2: improved handling of END_STREAM in a separate DATA frame.

The save body filter saves the request body to disk once the buffer is full.
Yet in HTTP/2 this might happen even if there is no need to save anything
to disk, notably when content length is known and the END_STREAM flag is
sent in a separate empty DATA frame. Workaround is to provide additional
byte in the buffer, so saving the request body won't be triggered.

This fixes unexpected request body disk buffering in HTTP/2 observed after
the previous change when content length is known and the END_STREAM flag
is sent in a separate empty DATA frame.

diffstat:

src/http/v2/ngx_http_v2.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diffs (13 lines):

diff -r 0dcec8e5d50a -r f302c1096f7b src/http/v2/ngx_http_v2.c
--- a/src/http/v2/ngx_http_v2.c Sun Aug 29 22:20:36 2021 +0300
+++ b/src/http/v2/ngx_http_v2.c Sun Aug 29 22:20:38 2021 +0300
@@ -4034,6 +4034,9 @@ ngx_http_v2_read_request_body(ngx_http_r

if (len < 0 || len > (off_t) clcf->client_body_buffer_size) {
len = clcf->client_body_buffer_size;
+
+ } else {
+ len++;
}

if (r->request_body_no_buffering && !stream->in_closed) {
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel