Welcome! Log In Create A New Profile

Advanced

[PATCH] Define phony make targets as such.

Thibault Nélis
February 04, 2021 06:50PM
Hello,

I just spent more time than I care to admit troubleshooting a make
issue after naively using `./configure --builddir=build` (make target
inadvertently matches this directory name).

Not sure if taking a dep on POSIX sed in the build system is kosher or
not, but if it is I figure this patch could save the next one some time
;).

Quickly tested on top of default tip as of this writing
(7765:519b55453c45).

Best regards,

--- a/auto/init
+++ b/auto/init
@@ -44,6 +44,8 @@ fi
 
 cat << END > Makefile
 
+.PHONY: default clean
+
 default:       build
 
 clean:
--- a/auto/install
+++ b/auto/install
@@ -196,6 +196,8 @@ done
 
 # create Makefile
 
+sed -i "/^\.PHONY/s/$/ build install modules upgrade/" Makefile
+
 cat << END >> Makefile
 
 build:


_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Define phony make targets as such.

Thibault Nélis 542 February 04, 2021 06:50PM

Re: [PATCH] Define phony make targets as such.

Maxim Konovalov 227 February 08, 2021 09:34AM

Re: [PATCH] Define phony make targets as such.

Thibault Nélis 255 February 08, 2021 01:58PM

Re: [PATCH] Define phony make targets as such.

Maxim Dounin 257 February 09, 2021 09:16AM

Re: [PATCH] Define phony make targets as such.

ru@nginx.com 361 February 20, 2021 04:48AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 249
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready