I thank you so much for your feedback.

It was my first attempt writing code of open source project. And I learned
many thing from Nginx codes and your feedback. Thank you for reviewing my
patchset.

Also I will look at AIO functionality and try to build external module.


SoYun

On Mon, Nov 30, 2020 at 11:39 PM Vladimir Homutov <vl@nginx.com> wrote:

> First, thank you for sharing the patchset!
>
> We are always looking at new features that appear in kernels and may be
> useful in nginx. There are a lof of shiny features, but it is a long
> way for them to mature and be adopted in nginx. Currently we are not
> considering adding such functionality.
>
> The io_uring interface looks like promising candidate to support AIO
> nginx functionality in linux. You may want to start looking at
> nginx.org/r/aio directive and related functionality. The task is
> quite complex (at some degree due to poor interfaces available),
> but we hope it has an elegant solution.
>
> Note also we prefer to use system calls directly, without introducing
> dependencies to such things like liburing (and for sure, the method
> of integration definitely is not cloning its copy in nginx).
>
> You may also want to consider building your modules externally and
> minimizing changes to nginx core. While patching nginx often seen
> as a simple and quick solution, we would appretiate attempts to
> integrate external code using some generic approach/interface.
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel