Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

Maxim Dounin
June 25, 2020 04:58AM
Hello!

On Wed, Jun 24, 2020 at 08:32:18PM +0900, Sokichi Takada wrote:

> In my case, the backend returns x-accel-expires with 304 responses every
> time.
>
> nginx calculates valid_sec by "ngx_http_upstream_process_accel_expires" for
> any revalidate or HIT responses, thus to get the wrong valid_sec value in
> header_filter/log hook handler.
> This patch has no impact to every response results, and to be able to get
> TRUE valid_sec value in the hook handlers.

No doubt the patch is working for you. But the patch breaks other
valid use cases.

On the other hand, the only thing it expected to do is to set the
valid_sec field, which is unused by nginx itself in you particular
use case, to something you think is "TRUE" for your particular use
case.

Again, thank you for the patch, but no.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

TAKADA Sokichi 111 June 18, 2020 08:42PM

Re: [PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

Maxim Dounin 34 June 21, 2020 05:12PM

Re: [PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

Sokichi Takada 32 June 22, 2020 04:10AM

Re: [PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

Maxim Dounin 27 June 22, 2020 06:38AM

Re: [PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

Sokichi Takada 33 June 24, 2020 07:34AM

Re: [PATCH] skip apply "ngx_http_upstream_process_accel_expires" when a request responeded by cache

Maxim Dounin 30 June 25, 2020 04:58AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 62
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready