Welcome! Log In Create A New Profile

Advanced

[nginx] gRPC: WINDOW_UPDATE after END_STREAM handling (ticket #1797).

April 23, 2020 08:12AM
details: https://hg.nginx.org/nginx/rev/716eddd74bc2
branches:
changeset: 7647:716eddd74bc2
user: Ruslan Ermilov <ru@nginx.com>
date: Thu Apr 23 15:10:26 2020 +0300
description:
gRPC: WINDOW_UPDATE after END_STREAM handling (ticket #1797).

As per https://tools.ietf.org/html/rfc7540#section-6.9,
WINDOW_UPDATE received after a frame with the END_STREAM flag
should be handled and not treated as an error.

diffstat:

src/http/modules/ngx_http_grpc_module.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diffs (13 lines):

diff -r 2096b21fcd10 -r 716eddd74bc2 src/http/modules/ngx_http_grpc_module.c
--- a/src/http/modules/ngx_http_grpc_module.c Thu Apr 23 15:10:24 2020 +0300
+++ b/src/http/modules/ngx_http_grpc_module.c Thu Apr 23 15:10:26 2020 +0300
@@ -2091,7 +2091,8 @@ ngx_http_grpc_filter(void *data, ssize_t
}

if (ctx->stream_id && ctx->done
- && ctx->type != NGX_HTTP_V2_RST_STREAM_FRAME)
+ && ctx->type != NGX_HTTP_V2_RST_STREAM_FRAME
+ && ctx->type != NGX_HTTP_V2_WINDOW_UPDATE_FRAME)
{
ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"upstream sent frame for closed stream %ui",
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[nginx] gRPC: WINDOW_UPDATE after END_STREAM handling (ticket #1797).

ru@nginx.com 804 April 23, 2020 08:12AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 313
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready