Welcome! Log In Create A New Profile

Advanced

[PATCH] Fix for the HT on request headers problem (#1752)

Anonymous User
January 20, 2020 10:30AM
# HG changeset patch
# User Marin Stavrev
# Date 1579526641 -7200
# Mon Jan 20 15:24:01 2020 +0200
# Node ID bf238762fdaf03383c2f3c3718c401e6141e3935
# Parent 6439ef81e37dfccfc3a8c57fed278bf56014ef39
Fix for the HT on request headers problem (#1752)

When client send HTTP request with a header of Content-Length that starts with
horizontal tab character (HT=0x09), Nginx responds with HTTP 400 Bad Request.
According to HTTP RFC2616 section 4.2, "... The field value MAY be preceded by
any amount of LWS, though a single SP is preferred.". The difinition of LWS is:

LWS = [CRLF] 1*( SP | HT )

So a header such as the following should be processed fine:

Content-Length:<0x09>110\r\n

diff -r 6439ef81e37d -r bf238762fdaf src/http/ngx_http_parse.c
--- a/src/http/ngx_http_parse.c Fri Jan 17 12:13:02 2020 +0300
+++ b/src/http/ngx_http_parse.c Mon Jan 20 15:24:01 2020 +0200
@@ -1000,6 +1000,7 @@
case sw_space_before_value:
switch (ch) {
case ' ':
+ case '\x9':
break;
case CR:
r->header_start = p;
@@ -1023,6 +1024,7 @@
case sw_value:
switch (ch) {
case ' ':
+ case '\x9':
r->header_end = p;
state = sw_space_after_value;
break;
@@ -1042,6 +1044,7 @@
case sw_space_after_value:
switch (ch) {
case ' ':
+ case '\x9':
break;
case CR:
state = sw_almost_done;

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Fix for the HT on request headers problem (#1752)

Anonymous User 155 January 20, 2020 10:30AM

Re: [PATCH] Fix for the HT on request headers problem (#1752)

Maxim Dounin 29 January 23, 2020 02:30PM

Re: [PATCH] Fix for the HT on request headers problem (#1752)

Marin Stavrev 41 January 24, 2020 02:10AM

Re: [PATCH] Fix for the HT on request headers problem (#1752)

Marin Stavrev 27 February 14, 2020 07:00AM

Re: [PATCH] Fix for the HT on request headers problem (#1752)

Maxim Dounin 29 February 18, 2020 11:04AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 78
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready