details: https://hg.nginx.org/nginx/rev/3939483cd1b5
branches:
changeset: 7600:3939483cd1b5
user: Maxim Dounin <mdounin@mdounin.ru>
date: Thu Dec 05 19:38:06 2019 +0300
description:
Upstream keepalive: clearing of c->data in cached connections.

Previously, connections returned from keepalive cache had c->data
pointing to the keepalive cache item. While this shouldn't be a problem
for correct code, as c->data is not expected to be used before it is set,
explicitly clearing it might help to avoid confusion.

diffstat:

src/http/modules/ngx_http_upstream_keepalive_module.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diffs (11 lines):

diff --git a/src/http/modules/ngx_http_upstream_keepalive_module.c b/src/http/modules/ngx_http_upstream_keepalive_module.c
--- a/src/http/modules/ngx_http_upstream_keepalive_module.c
+++ b/src/http/modules/ngx_http_upstream_keepalive_module.c
@@ -275,6 +275,7 @@ found:

c->idle = 0;
c->sent = 0;
+ c->data = NULL;
c->log = pc->log;
c->read->log = pc->log;
c->write->log = pc->log;
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel