Hello!

On Tue, Apr 30, 2019 at 04:16:29PM +0900, 서정훈 wrote:

> Hi.
>
> The user-agent of ie11 running on windows10 can not be parsed by "MSIE".
>
> This causes headers_in.msie to remain zero.
>
> source code location:
> https://github.com/nginx/nginx/blob/master/src/http/ngx_http_request.c#L1823
>
> When I checked it, I found that it was possible to parse it with "rv:11.0".
>
> Is there any reason not to patch this?

I don't think it worth fixing. This was IE team deleberate
decision to stop being detected as IE[1], and I generally agree -
browser detection is evil and should not be used as soon as there
are other options. In nginx, there is no real need to detect IE11
(and probably nobody cares about IE now anyway).

[1] https://blogs.msdn.microsoft.com/ieinternals/2013/09/21/internet-explorer-11s-many-user-agent-strings/

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel