August 08, 2018 03:46PM
Hi,

>
> - The code bypasses open file cache, and uses a direct call
> in the http cache code instead. While it might be ok in your
> setup, it looks like an incomplete solution from the generic point
> of view. A better solution would be to introduce a generic
> interface in ngx_open_cached_file() to allow use of thread
> pools.
>

A small comment on this - I wrote such an implementation a while ago
in my module. We've been using it on production for the last ~3 years.

Code is here -
https://github.com/kaltura/nginx-vod-module/blob/master/ngx_async_open_file_cache.c

(There's a lot of code there that was copied from ngx_open_file_cache.c,
I did that since those functions are static, and didn't want to change nginx core.
If implemented as part of nginx core, all this duplication can be avoided...)

In my implementation, I added a function similar to ngx_open_cached_file -
(ngx_async_open_cached_file), that gets a few extra params -
1. The thread pool
2. The thread task (optional) - this was done in order to reuse the task
when opening multiple files in a single request
3. Callback + context - invoked once the async open completes

This function first checks the cache, if there's a hit, it returns synchronously
(NGX_OK).
Otherwise, it posts a task that does ngx_open_and_stat_file (NGX_AGAIN).
When the task completes, the main nginx thread updates the cache, and invokes
the user callback.

Hope this helps...

Eran

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 936 August 07, 2018 05:28PM

Re: cache: move open to thread pool

Maxim Dounin 192 August 08, 2018 02:18PM

RE: cache: move open to thread pool

erankor 169 August 08, 2018 03:46PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 136 August 27, 2018 06:00PM

RE: cache: move open to thread pool

erankor 151 August 28, 2018 05:18AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 152 August 09, 2018 05:44PM

Re: cache: move open to thread pool

Maxim Dounin 155 August 10, 2018 07:42AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 127 August 27, 2018 05:40PM

Re: cache: move open to thread pool

Maxim Dounin 208 September 03, 2018 12:10PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 136 September 04, 2018 08:00PM

Re: cache: move open to thread pool

Maxim Dounin 143 September 13, 2018 02:12PM

Re: cache: move open to thread pool

Roman Arutyunyan 200 October 04, 2018 05:34AM

Re: cache: move open to thread pool

Roman Arutyunyan 271 November 01, 2018 08:30AM

Re: cache: move open to thread pool

Maxim Konovalov 137 November 01, 2018 12:08PM

Re: cache: move open to thread pool

Maxim Konovalov 147 November 08, 2018 09:20AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 129 November 15, 2018 05:54PM

Re: cache: move open to thread pool

Maxim Konovalov 141 November 16, 2018 04:12AM

Re: cache: move open to thread pool

Maxim Konovalov 142 December 05, 2018 04:44AM

Re: cache: move open to thread pool

Maxim Konovalov 104 January 10, 2019 03:32AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 110 January 14, 2019 08:54PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 82 January 22, 2019 01:22PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 109 January 22, 2019 02:36PM

Re: cache: move open to thread pool

Maxim Konovalov 98 January 23, 2019 07:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 81 February 06, 2019 04:20PM

Re: cache: move open to thread pool

Maxim Konovalov 90 February 07, 2019 08:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 131 February 08, 2019 05:42PM

Re: cache: move open to thread pool

karton 22 July 19, 2019 11:28AM

Re: cache: move open to thread pool

Maxim Konovalov 27 July 19, 2019 02:44PM

Re: cache: move open to thread pool

karton 23 July 19, 2019 09:46PM

Re: cache: move open to thread pool

Roman Arutyunyan 17 July 22, 2019 10:06AM

Re: cache: move open to thread pool

karton 21 July 22, 2019 11:40AM

Re: cache: move open to thread pool

karton 25 July 23, 2019 11:48PM

Re: cache: move open to thread pool

Roman Arutyunyan 4 August 16, 2019 10:26AM

Re: cache: move open to thread pool

karton 5 August 16, 2019 10:52AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 86
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready