Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Core: remove unused FIOASYNC.

June 28, 2018 05:30AM
On Wed, Jun 27, 2018 at 01:40:26PM -0700, Ian Gudger wrote:
> Sorry, I understand now.
>
> Here is a new patch which removes that too:
>
> # HG changeset patch
> # User Ian Gudger <igudger@google.com>
> # Date 1529449008 25200
> # Tue Jun 19 15:56:48 2018 -0700
> # Node ID 8fd0b85081a1cb91fa4495258bb5f9d3a6ef5785
> # Parent 118885f7a5774962f1145693d9c26a4c199ca6ea
> Core: remove FIOASYNC as the SIGIOs it generated were ignored.
>
> FIOASYNC and F_SETOWN cause a pid or pgid to receive signals when a file is
> ready for IO. When using master process mode, this was setup, but the SIGIO
> signals were ignored. This has been the case since use of FIOASYNC was first
> added in eaf1f651cf86. Logic ignore the SIGIOs in a case where they
> unintentionally did something was added in 8abb88374c6c.
>
> diff --git a/src/os/unix/ngx_process.c b/src/os/unix/ngx_process.c
[...]
> @@ -433,8 +411,6 @@ ngx_signal_handler(int signo, siginfo_t
>
> case ngx_signal_value(NGX_RECONFIGURE_SIGNAL):
> case ngx_signal_value(NGX_CHANGEBIN_SIGNAL):
> - case SIGIO:
> - action = ", ignoring";
> break;
> }

On Wed, Jun 27, 2018 at 03:57:05PM +0300, Ruslan Ermilov wrote:
> Removing setting of an "action" variable looks like an error.

No need to resend the patch.
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Core: remove unused FIOASYNC.

Ian Gudger via nginx-devel 166 June 25, 2018 02:18PM

Re: [PATCH] Core: remove unused FIOASYNC.

ru@nginx.com 65 June 27, 2018 08:58AM

Re: [PATCH] Core: remove unused FIOASYNC.

Ian Gudger via nginx-devel 66 June 27, 2018 01:12PM

Re: [PATCH] Core: remove unused FIOASYNC.

ru@nginx.com 64 June 27, 2018 02:34PM

Re: [PATCH] Core: remove unused FIOASYNC.

Ian Gudger via nginx-devel 69 June 27, 2018 04:42PM

Re: [PATCH] Core: remove unused FIOASYNC.

ru@nginx.com 66 June 28, 2018 05:30AM

Re: [PATCH] Core: remove unused FIOASYNC.

ru@nginx.com 67 June 28, 2018 07:48AM

Re: [PATCH] Core: remove unused FIOASYNC.

Ian Gudger via nginx-devel 43 July 09, 2018 02:38AM

Re: [PATCH] Core: remove unused FIOASYNC.

ru@nginx.com 78 July 11, 2018 10:22AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 113
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready