Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Contrib: vim syntax, support block region

Maxim Dounin
April 21, 2017 09:48AM
Hello!

On Fri, Apr 21, 2017 at 04:39:03PM +0800, OOO wrote:

> Actually nginx.vim supports on and off[1] before.
> And some option also been highlighted because there are directives
> with the same name, ex: ssl.
> So if we complete remove this.
> It will looks like the function is missing.

Yes, but this highlighting is not directive-specific. Nothing
stops from highlighting some parameters in all directives, and
this is what I did in the PoC to preserve compatibility with the
previous versions of highlighting.

On the other hand, I really think that highlighting of "on / off"
in directives which do not handle these parameters is a
misfeature, and in many cases it misleads people to think that a
given directive does support on / off parameters.

--
Maxim Dounin
http://nginx.org/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 1 of 4] Contrib: vim syntax, allow multiline config by skipempty

othree 579 March 03, 2017 05:58AM

[PATCH 3 of 4] Contrib: vim syntax, highlight HTTP status code

othree 269 March 03, 2017 05:58AM

[PATCH 2 of 4] Contrib: vim syntax, highlight rewrite flag

othree 245 March 03, 2017 05:58AM

[PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

othree 221 March 03, 2017 05:58AM

Re: [PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

Maxim Dounin 223 March 03, 2017 09:06AM

Re: [PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

OOO 269 March 03, 2017 10:40AM

Re: [PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

Maxim Dounin 262 March 03, 2017 12:26PM

[PATCH] Contrib: vim syntax, support block region

othree 276 March 04, 2017 07:00AM

Re: [PATCH] Contrib: vim syntax, support block region

OOO 273 March 10, 2017 11:46AM

Re: [PATCH] Contrib: vim syntax, support block region

Maxim Dounin 251 March 10, 2017 11:54AM

Re: [PATCH] Contrib: vim syntax, support block region

OOO 229 March 10, 2017 11:58AM

Re: [PATCH] Contrib: vim syntax, support block region

OOO 209 April 19, 2017 05:54AM

Re: [PATCH] Contrib: vim syntax, support block region

Maxim Dounin 193 April 19, 2017 11:12AM

Re: [PATCH] Contrib: vim syntax, support block region

OOO 199 April 21, 2017 04:40AM

Re: [PATCH] Contrib: vim syntax, support block region

Maxim Dounin 238 April 21, 2017 09:48AM

Re: [PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

OOO 280 March 04, 2017 07:20AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 292
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready