Welcome! Log In Create A New Profile

Advanced

Add missing static specifiers

February 28, 2017 02:22PM
Hi all,

Wrote a small script to find missing 'static's in my module -
https://github.com/kaltura/nginx-vod-module/blob/master/test/test_static.py

I executed it on nginx core and found a few of those too, see attached patch.
The logic for finding these was -

1. An exported symbol (found by running readelf on all object files)

2. Appears only in one source file (I could have checked the object imports instead, but anyway,
that's how it works...)

3. Not mentioned in any header file (simple 'find whole words' search)

4. Does not end with '_module'

Btw, the script also complained about ngx_noaccepting and ngx_restart, I did not change those since
all other flags there are exported.

Thanks!

Eran
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Add missing static specifiers Attachments

erankor 973 February 28, 2017 02:22PM

Re: Add missing static specifiers

Maxim Dounin 480 February 28, 2017 03:24PM

RE: Add missing static specifiers Attachments

erankor 761 February 28, 2017 04:22PM

Re: Add missing static specifiers

Maxim Dounin 460 March 01, 2017 07:40PM

RE: Add missing static specifiers Attachments

erankor 709 March 02, 2017 02:16AM

Re: Add missing static specifiers

Maxim Dounin 480 March 02, 2017 08:38AM

RE: Add missing static specifiers Attachments

erankor 708 March 02, 2017 08:54AM

Re: Add missing static specifiers

Maxim Dounin 437 March 02, 2017 10:52AM

RE: Add missing static specifiers

erankor 741 March 02, 2017 04:34PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 143
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready