Welcome! Log In Create A New Profile

Advanced

Re: Why not remove UNIX domain socket before bind

Datong Sun via nginx-devel
December 01, 2016 04:18AM
Hi Maxim,

Thanks for the explanation. Regarding a), what about checking and making
sure the type of file is actually a socket before removing? Obviously it
does not prevent NGINX from deleting sockets created by other processes but
it's a much smaller issue compared to deleting arbitrary file.

Thanks,

On Wed, Nov 30, 2016 at 6:57 AM, Maxim Dounin <mdounin@mdounin.ru> wrote:

> Hello!
>
> On Tue, Nov 29, 2016 at 01:30:25PM -0800, Shuxin Yang wrote:
>
> > Is there any reason not to delete UNIX domain socket before bind?
>
> To name a few, deleting a socket implies that:
>
> a) any file can be accidentally deleted due to a typo in the
> listen directive;
>
> b) attempts to do duplicate listen are not detected and silently
> break service, e.g., if you start duplicate instance of nginx.
>
> Instead we delete the socket after closing it.
>
> --
> Maxim Dounin
> http://nginx.org/
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>



--

*Datong Sun* | Systems Engineer
datong@cloudflare.com
https://www.cloudflare.com/

1 888 99 FLARE | www.cloudflare.com
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Why not remove UNIX domain socket before bind

Shuxin Yang 720 November 29, 2016 04:32PM

Re: Why not remove UNIX domain socket before bind

Datong Sun via nginx-devel 395 November 30, 2016 02:12AM

Re: Why not remove UNIX domain socket before bind

Shuxin Yang 420 November 30, 2016 02:40AM

Re: Why not remove UNIX domain socket before bind

Maxim Dounin 312 November 30, 2016 09:58AM

Re: Why not remove UNIX domain socket before bind

Shuxin Yang 314 November 30, 2016 11:32AM

Re: Why not remove UNIX domain socket before bind

Datong Sun via nginx-devel 350 December 01, 2016 04:18AM

Re: Why not remove UNIX domain socket before bind

Alexey Ivanov 334 December 01, 2016 04:22AM

Re: Why not remove UNIX domain socket before bind

Maxim Dounin 405 December 01, 2016 08:48AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 326
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready