Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora
June 28, 2016 05:26PM
Hey Maxim,

> There was at least one attempt to introduce a code using both
> fcntl(F_READAHEAD) and posix_fadvise() depending on a
> configuration. And I don't think this should be prevented at
> configure stage.

This code isn't part of current NGINX codebase, so it's a moot point.

Once fallbacks to alternatives are added to the code (and I might add
some myself), it's trivial to re-enable them in the ./configure script
on case-by-case basis, but right now those tests for alternatives are
just pointless and waste CPU cycles.

Furthermore, sometimes those tests warn about issues in features that
aren't going to get used anyway, because preferred feature was already
found.

For example, on OSX, you'll see this:

checking for mmap(MAP_ANON|MAP_SHARED) ... found
checking for mmap("/dev/zero", MAP_SHARED) ... found but is not working
checking for System V shared memory ... found

Best regards,
Piotr Sikora

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 607 June 27, 2016 10:58PM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

ru@nginx.com 615 June 28, 2016 08:56AM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Maxim Dounin 389 June 28, 2016 09:26AM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 388 June 28, 2016 05:26PM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 388 June 28, 2016 05:18PM

[PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 408 June 28, 2016 06:28PM

[PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 380 June 28, 2016 06:30PM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Maxim Dounin 388 June 30, 2016 10:18AM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 443 June 30, 2016 03:46PM

[PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 395 June 30, 2016 03:46PM

[PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 384 June 30, 2016 03:54PM

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Piotr Sikora 401 June 30, 2016 03:58PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 182
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready