Welcome! Log In Create A New Profile

Advanced

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Maxim Dounin
November 03, 2014 07:56PM
Hello!

On Mon, Nov 03, 2014 at 02:35:33PM -0800, Yichun Zhang (agentzh) wrote:

> Hello!
>
> On Mon, Nov 3, 2014 at 2:03 PM, Maxim Dounin wrote:
> >
> > The change is 1.7.7 is intentional, please see
> > http://hg.nginx.org/nginx/rev/973fded4f461.
> >
>
> Yes, I was aware of this commit. This commit introduces real issues on
> my side because even if the gzip filter does not have busy bufs, the
> downstream write filter can have busy bufs. And it's wrong to avoid
> flushing downstream busy bufs just when ngx_gzip itself does not have
> busy bufs.

The commit log in question explains the reason for the change.
Work on the gzip stalls problem as fixed by 973fded4f461 clearly
showed that just passing NULL chains is wrong unless last buffer
was already sent or there are busy buffers. And after the
c52a761a2029 change there were at least two reports about "output
chain is empty" alerts.

If you see an issue, you may want to share the issue details,
to find out how to fix it properly.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Yichun Zhang (agentzh) 1094 October 31, 2014 09:22PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Maxim Dounin 348 November 03, 2014 05:06PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Yichun Zhang (agentzh) 360 November 03, 2014 05:36PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Maxim Dounin 390 November 03, 2014 07:56PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Yichun Zhang (agentzh) 354 November 04, 2014 03:44PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Maxim Dounin 469 November 05, 2014 10:42AM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Yichun Zhang (agentzh) 303 November 05, 2014 08:04PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Yichun Zhang (agentzh) 336 November 05, 2014 08:10PM

Re: Gzip Gunzip: always flush busy bufs when the incoming chain is NULL.

Yichun Zhang (agentzh) 375 November 10, 2014 05:26PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 321
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready